all repos — dwm @ dce4fb373757727374d00c857ec0dfd225bbeafd

my dwm build

setfullscreen: don't process the property twice

Some clients try to set _NET_WM_STATE_FULLSCREEN even when the window is
already in fullscreen.
For example, c->oldstate was set two times in a raw and window would
then always be floating.
We must check that it's not the case before processing it.
(original patch modified with suggestion from Markus Teich
<markus.teich@stusta.mhn.de>)
Quentin Rameau quinq+hackers@fifth.space
Sat, 07 Nov 2015 14:09:08 +0100
commit

dce4fb373757727374d00c857ec0dfd225bbeafd

parent

646b351cc79845f4cc77415dfff474b9ae0053d9

1 files changed, 2 insertions(+), 2 deletions(-)

jump to
M dwm.cdwm.c

@@ -1441,7 +1441,7 @@ }

void setfullscreen(Client *c, Bool fullscreen) { - if(fullscreen) { + if(fullscreen && !c->isfullscreen) { XChangeProperty(dpy, c->win, netatom[NetWMState], XA_ATOM, 32, PropModeReplace, (unsigned char*)&netatom[NetWMFullscreen], 1); c->isfullscreen = True;

@@ -1452,7 +1452,7 @@ c->isfloating = True;

resizeclient(c, c->mon->mx, c->mon->my, c->mon->mw, c->mon->mh); XRaiseWindow(dpy, c->win); } - else { + else if(!fullscreen && c->isfullscreen){ XChangeProperty(dpy, c->win, netatom[NetWMState], XA_ATOM, 32, PropModeReplace, (unsigned char*)0, 0); c->isfullscreen = False;