using a global stack for focus recovery on arrange() - seems to work great
Anselm R. Garbe arg@10kloc.org
Thu, 07 Sep 2006 17:53:40 +0200
M
client.c
→
client.c
@@ -11,6 +11,14 @@
/* static functions */ static void +detachstack(Client *c) +{ + Client **tc; + for(tc=&stack; *tc && *tc != c; tc=&(*tc)->snext); + *tc = c->snext; +} + +static void grabbuttons(Client *c, Bool focus) { XUngrabButton(dpy, AnyButton, AnyModifier, c->win);@@ -99,6 +107,9 @@ drawtitle(old);
} } if(c) { + detachstack(c); + c->snext = stack; + stack = c; grabbuttons(c, True); drawtitle(c); XSetInputFocus(dpy, c->win, RevertToPointerRoot, CurrentTime);@@ -198,7 +209,6 @@
void manage(Window w, XWindowAttributes *wa) { - unsigned int i; Client *c; Window trans; XSetWindowAttributes twa;@@ -247,7 +257,8 @@
if(clients) clients->prev = c; c->next = clients; - clients = c; + c->snext = stack; + stack = clients = c; settitle(c); ban(c);@@ -421,6 +432,7 @@
XUngrabButton(dpy, AnyButton, AnyModifier, c->win); XDestroyWindow(dpy, c->twin); + detachstack(c); free(c->tags); free(c);
M
dwm.h
→
dwm.h
@@ -61,6 +61,7 @@ Bool isfloat;
Bool *tags; Client *next; Client *prev; + Client *snext; Window win; Window twin; };@@ -73,7 +74,7 @@ extern void (*handler[LASTEvent])(XEvent *);
extern void (*arrange)(Arg *); extern Atom wmatom[WMLast], netatom[NetLast]; extern Bool running, issel, maximized, *seltag; -extern Client *clients, *sel; +extern Client *clients, *sel, *stack; extern Cursor cursor[CurLast]; extern DC dc; extern Display *dpy;
M
view.c
→
view.c
@@ -76,8 +76,10 @@ }
else ban(c); } - if(!sel || !isvisible(sel)) - focus(getnext(clients)); + if(!sel || !isvisible(sel)) { + for(sel = stack; sel && !isvisible(sel); sel = sel->snext); + focus(sel); + } restack(); }@@ -138,8 +140,10 @@ }
else ban(c); } - if(!sel || !isvisible(sel)) - focus(getnext(clients)); + if(!sel || !isvisible(sel)) { + for(sel = stack; sel && !isvisible(sel); sel = sel->snext); + focus(sel); + } restack(); }@@ -227,7 +231,7 @@ if(sel->isfloat || arrange == dofloat) {
XRaiseWindow(dpy, sel->win); XRaiseWindow(dpy, sel->twin); } - if(arrange != dofloat) + if(arrange != dofloat) for(c = nexttiled(clients); c; c = nexttiled(c->next)) { XLowerWindow(dpy, c->twin); XLowerWindow(dpy, c->win);