all repos — slstatus @ 35f7862744288411600b5200e3612b4ed204092d

my build of slstatus (tools.suckless.org/slstatus/)

simplified run_command()
Ali H. Fardan raiz@firemail.cc
Wed, 14 Sep 2016 16:20:20 +0300
commit

35f7862744288411600b5200e3612b4ed204092d

parent

56fffbce64e2ee66891dbe3f2b8b9b4f9cb284bc

1 files changed, 4 insertions(+), 12 deletions(-)

jump to
M slstatus.cslstatus.c

@@ -406,26 +406,18 @@

static char * run_command(const char* command) { - int good; FILE *fp = popen(command, "r"); - char buffer[64] = ""; + char buffer[64]; if (fp == NULL) { warn("Could not get command output for: %s", command); return smprintf(UNKNOWN_STR); } - fgets(buffer, sizeof(buffer)-1, fp); - pclose(fp); - for (int i = 0 ; i != sizeof(buffer); i++) { - if (buffer[i] == '\0') { - good = 1; - break; - } - } - if (good) - buffer[strlen(buffer)-1] = '\0'; + fgets(buffer, sizeof(buffer), fp); + buffer[sizeof(buffer)-1] = '\0'; + pclose(fp); return smprintf("%s", buffer); }