Implement fmt_scaled for disk_* functions

Add fmt_scaled util function

Use %d instead of accidentally %i

Port battery_remaining to Linux

Additionally unify the format of battery_state and uptime

Fix memory leak

battery: fixed remaining time on connected AC

when an AC is connected apm_info shows a non-valid value for remaining
minutes. it was decided that in that case the function should return an
empty string.

Fix indentation

Tabs for indentation, spaces for alignment

Add battery_remaining function on OpenBSD

Implementation of a battery_remaining function which returns the
remaining battery time in HH:MM format. Linux function still needs
implementation.
Move common code to load_apm_power_info

Add warn() and die()

Given slstatus is a tool that runs in the background, most likely run
from .xinitrc, it's important to prepend the name of the tool to error
messages so it becomes clear where the error is coming from.

To make this much more consistent, this commit adds warn() and die()
utility functions consistent with other suckless projects and adapts all
calls to fprintf(stderr, *) to the warn() and die() functions, greatly
increasing the readability of the code.

Audit slstatus.c

 1) Remove setlocale() (locales are harmful and any 'issues' shall
    be fixed in different ways that are expected).
 2) Disable buffering on stdout with setbuf() rather than flushing
    it each time.
 3) Make error messages more consistent.
 4) Add error checks where applicable.
 5) Make code a bit more readable where res is assigned.
 6) Use XFlush() rather than XSync() (we don't need to wait for the
    XServer to react, which could lead to long hangs on our side).

Properly handle *snprintf() errors

Posix guarantees that the resulting string is null-terminated, even if
we have an overflow. Instead of doing what has already been done,
properly warn when there has been an error or overflow, so the user can
do something about it.

Remove UNUSED macro

Use variables named unused instead which is simpler

Mark unused parameters, fix compiler warnings

wifi: Fix order and add missing header

<sys/select.h> is needed before <net80211/ieee80211_ioctl.h> on OpenBSD
to define NBBY and shut up compiler warnings.

wifi: Change memmove to memcpy on OpenBSD

Unify type of  in for loops

wifi_essid: Fix coding style

Only initialize variables at the beginning of a block

Unify type of `i` in for loops

int for normal indexes
size_t for usage with the LEN macro

Change done to int as it is the CPU's natural type

Change interval to unsigned int

Add comments for battery_* functions on OpenBSD

added comment for temp function (openbsd)

corrected calculations for disk space on openbsd

Update README

wifi: Fix coding style

Use block for single statement ifs
When functions return -1 for error test against 0 not -1
Newlines

load_ieee80211_nodereq: Fix typo

wifi: Move out common headers

added wifi functionality for openbsd

display ESSID and signal strength percentage

corrected calculation for swap on openbsd

The swapctl(2) function fills the swapent struct with 512KB blocks.
As we want to display in GB, i just modified the calculation for this to
get the expected output.

consistent calculation of ram_* on openbsd

Add he4d to LICENSE

updated ram_total and ram_free (obsd)

Cast CPU percentage to int and fix indenation

fflush(stdout) to print line by line if stdout is not a tty

To reproduce the issue:
	$ slstatus -s | tee

then it would print only when the stdout buffer is full, by block
of multiple lines.

fflush() makes sure the line is printed at every loop iteration

Add josuah to LICENSE

include <sys/time.h> before <sys/sensors.h> for time struct timeval

sys/sensors.h has two structs struct timeval: sensor and ksensor:

	struct sensor {
		...
		struct timeval tv;		/* sensor value last change time */
		...
	};

Only variable declarations at top of block

Fix indents (spaces for alignment)

wifi_perc: Simplify

num_files: Variable declarations at top of block

Fix disk_perc by casting it to int

disk_perc: Simplify

cpu: Simplify functions

Unify header includes

- Sort Alphabetically
- Same indentation for preprocessor clauses

entropy: Small fix

entropy: Port to OpenBSD

OpenBSD's entropy design is superior to Linux.

datetime: Add <stdio.h> for fprintf

datetime: Add error message

Fix coding style

- Use block for single statement ifs
- Keep lines to reasonable length (current debate as to reasonable)
- When functions return -1 for error test against 0 not -1
- Do not indent cases another level
- Do not test against NULL and 0 explicitly
- Use tabs for indentation, use spaces for alignment

Remove cpu_iowait

The third value from load_avg (idle) gives us almost the same
information as cpu_iowait. Plus OpenBSD does not offer an iowait value
as Linux and thus the corresponding function would not be portable.

cpu_perc: Documentation and readbility improvements

cpu_perc: Port to OpenBSD

In OpenBSD the CPU usage in percent is now computed using KERN_CPTIME
sysctl.

swap_*: Port to OpenBSD

battery: Remove full indicator

It does not respect charging thresholds and it is not trivial to
implement the indicator in OpenBSD.

wifi_perc: Fix file descriptor leak

Add examples to config.def.h

uptime: Add missing brace

volume: Cast SOUND_MIXER_READ_DEVMASK to int to avoid warning.

wifi: Various cleanups

user: Only declare variables in the beginning

uptime: Simplifiy and clean up

run_command: Clean up

keyboard_indicators: Clean up opening display

ip: Sort headers alphabetically

battery_state: Unify unknown state with "?" symbol

Update README todo

Remove battery_power for various reasons

- Battery power cannot be easily gatherable via apm(4)
- IMHO it does not represent essential information

Tweak build system a little bit

Be consistent with brackets and add a comment for OpenBSD to make it
clearer what the actual intent of the uncommented line is.

In the Makefile, add a dependency of slstatus.o from config.mk.

battery_perc: Port to OpenBSD

components/swap.c | move duplicated code to separate function

Use indentation to increase readability

Granted, this style is definitely not common, but for the short
utility-functions of this program it's just the right choice. This
provides great flexibility, such that in the long run, it will be
possible to also share code between the OS-implementations.

This also keeps the state-keeping at a minimum and makes it clearer
which functions are implemented on which OS without having to jiggle
around with too many files in the process.

Revert component-split

this reverts the commits from 92ab9ef52ebcb097add97d9f78e67ad1c1d6a6ec up to
d42870d6ca7fb587b38f8cf6d6821ae33a53a696.

After heavy consideration, the component split has more disadvantages
than advantages, especially given there will be utility-functions
sharing quite a lot of code that would then need to be duplicated, as it
does not fit into the util.c due to its speciality.

One big advantage of the component-wise build is readability, and
without doubt, this was achieved here. This point will be addressed
with a different approach that will be visible in the upcoming commits.

One big disadvantage of the component build is the fact that it
introduces state to the build process which is not necessary. Before its
introduction, the only influencing factors where the system-defines
__linux__ and __OpenBSD__. With the components, we are also relying on
the output of uname(1).
Additionally, if the os.mk is not present, make gives the output

     $ make
     Makefile:5: os.mk: No such file or directory
     make: *** No rule to make target 'os.mk'.  Stop.

This could easily be fixed by providing some sort of meta-rule for this
file, however, it indicates the problem we have here, and this entire
statefulness will heavily complicate packaging of this tool and makes
the build process much more complex than it actually has to be.

Makefile: add distclean target

Makefile: move OS-specific libs to configure script

Makefile: separate default flags from user flags

Update LICENSE for Quentin Rameau

wifi: OS split

uptime: OS split

temperature: OS split

swap: OS split

ram: OS split

entropy: OS split

cpu: OS split

battery: OS split

Makefile: detect running OS

cpu_freq: Port to OpenBSD

In OpenBSD CPU frequency gets fetched using sysctl now.

Fix typo in temperature

Update README for OpenBSD build

uptime: Separate function for readbility

battery: Separate function for readbility

ram: Move up includes

Sort LICENSE according to first commit

temp: Port to OpenBSD

In OpenBSD temperature gets fetched using sysctl now.

Remove vol_perc() from todo in README

Update LICENSE for parazyd

Add OpenBSD support in volume.c

Update LICENSE for Ali H. Fardan

Remove ipv{4,6}() from todo in README

ip: add OpenBSD support

ip.c already works on OpenBSD, it's just missing some headers:

Remove non-portable functions from config.def.h

Add Darron Anderson to LICENSE

Thank you for your contribution.

Remove ram_*() from README

Add OpenBSD RAM stats

Format error messages properly

Make use of strerror(errno) and format all errors equally:
function ['parameters']: error message

Remove program name from error messages

Get rid of err.h as it is not portable

Replace warn() and warnx() with fprintf() and add <stdio.h> where
necessary.

Remove unnecessary headers

Remove ALSA dependency from README

ALSA is not a dependency anymore as we use /dev/mixer. The corresponding
notice about PulseAudio is thus not necessary too.

More robust preprocessor switches

Replace #ifdef with #if defined() and #elif with #elif defined() as it
should only test if it is defined or not.

uptime: Port to OpenBSD.

In OpenBSD uptime gets fetched using sysctl now.

battery_perc: Port to OpenBSD.

In OpenBSD battery percentage gets fetched using apm now.

README: Add list of non-portable functions

Build Linux-only functions only on Linux

README: Add Todo

Merge pull request #43 from SiIky/unknown_str

Print unknown_str in case of error

Update LICENSE year for myself.

Fix a bug in wifi_essid().

When an invalid interface name is passed to wifi_essid() it does not
close opened sockets.

Small fixes in config.mk

Update LICENSE for parazyd

Return actual percentage for wifi_perc()

Implement basic percentage calculation for wifi_perc. With this
commit, the function returns correct percentage, since the max
of what /proc/net/wireless returns is 70.

Move components into dedicated subdirectory

This brings us a lot more tidiness.

Get rid of HDR variable

The HDR variable is used for general purpose headers, which are not
given in this project. arg.h and config.h are only needed for
slstatus.c, not every component $(COM:=.c).

This also fixes a problem introduced in
e04a3853643df1c98a451969d515d8850f138bcc, where config.h is pulled into
the tarball.

Simplify Makefile

Fix missing config.h in Makefile

Added LICENSE statements to all source files

Properly declare buf as extern and fix all unused-warnings

Rewrite Makefile to accomodate file split

Split into multiple files

For multiple reasons the program is now split:
- Make future porting to OpenBSD easier
- Assign header includes to individiual functions
- Make future program extensions easier
- Recompile only changed parts

Add blank line after setlocale

setlocale() has to be separated from the signal handling.

slstatus: set locale

I want my date & time printed according my locale settings.
This commit enables that

Signed-off-by: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>

Added CPU iowait to README

slstatus: add cpu_iowait

This commit introduces the cpu_iowait item, this is the percentage
of cpu time spent waiting on disks. High numbers typically indicate
that your system is not responsive due to disk IO.
This commit also avoid sleeping inside the cpu_perc and cpu_iowait
functions: waiting in either one implies lost info for the other.

Signed-off-by: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>

Deleted slstatus.png as it is unnecessary

slstatus load_avg format string

Added IPv6 address function

- Renamed "ip" function to "ipv4"
- Added "ipv6" function
- Adjusted README and config.def.h accordingly

sexy config.def.h table

Fix a little logic error

Add pscanf()

This reduces a lot of equivalent code to one function call.

Refactor main()

We remove the hack with the sleep and global "delay"-variable and use a
monotonic clock to derive the desired monotonic properties of the tool.
Inside each function that demands a personal delay we can then just do a
nanosleep() and be done with it.
It's a shame that timespec is so ugly to work with, but there's really
no way to make it more beautiful. However, at this cost though we
finally can set the interval times in milliseconds and not only just
seconds.

We remove setlocale(), because nothing good ever came out of this
function.

Besides that we have some more code refactoring, especially in the
argument loop which saves us a bit of complexity.

Simplify signal handling a bit

Remove unnecessary prototypes

Remove unnecessary blank lines after license-notice

Fix man page .Os field

Added Makefile target for distribution tarballs.

Fixed man page path

According to the FHS, /usr/local/share/man is the correct man page path
in this projects's case. Set this to default in config.mk.

slstatus != dmenu lol

Removed #define for unknown_str

Debugging #define is very difficult. The performance overhead of static const
char is negligible.

Removed #define for update interval

Debugging #define, especially in mathematical constructs is very
difficult. The performance overhead of static const int is negligible.

Updated LICENSE

Extended Ali H. Fardan contribution dates

keyboard_indicators: fix segfault when -s is specified

Fixed possible NULL-deref and removed unnecessary XOpenDisplay()

- Added a check for the return value of XOpenDisplay() in main().
  This fixes a possible NULL-deref.
- Removed unnsecessary XOpenDisplay and XCloseDisplay from
  keyboard_indicators(). The ones in main() are sufficent.

Add and use LEN() macro

Refactor battery_state()

Reformatted LICENSE to fit 75 character width

Print usage() when we are left with arguments

Reduce -o | -n to -s

What we really want is to either output to WM_NAME or stdout. If we want
just one single line, we do slstatus | head -n 1.

Remove d- and v-flags

d-flag: There's no need for that, use the &-operator or fork+exec in a
        non-shell-context. In the latter case you get the PID for free.
v-flag: If you want to find out which version of a package is installed,
        consult your package manager. That's his job.

Convert slstatus.1 to mandoc, simplify it and remove -h

We also change the semantics of -v to only return the version
information.
There is now no need for usage() to exit with anything other than 1.

Refactor build system

New README in plain text

Removed TODO.md

Removed CONTRIBUTING.md

Moved contributors to LICENSE

Copyright sign (C) is not required in LICENSE

According to https://opensource.org/licenses/ISC

Removed .gitignore from repository

A file outside the repository (.git/info/exclude) can replace this and
suits better for this usecase.

new arg.h version by frign

add num_files() function for maildirs ;)

updated readme

check for fgets/fscanf return values

use a static buffer instead of dynamic memory

remove format characters from stat functions

add cpu_freq function

add battery_power function

added option to output only once and exit afterwards

enable stack protector and compile to position independent executable

simplified and improved vol_perc()

fix overflow in run_command()

username(): get rid of unneeded uid variable

Merge pull request #39 from stoeckmann/fgets

On success, fgets always terminates the result.

Merge pull request #38 from stoeckmann/terminating-nul

Fixed out of boundary write on long lines.

loading thresholds state

Fixed XCloseDisplay() which is not reached in keyboard_indicators()

Added keyboard_indicators (Fixes #31)

Makefile fix and vol_perc fix for mute

simplified Makefile

small Makefile tweak

Makefile: Added back config.h handling in Makefile

Makefile: Fixes #35

todo

removed ./extern/

removed strlcat dependency (was used only once)

got rid of concat.h

saner makefile: cleaner, simpler, suckless

happy new year!

run_command: strlen() will not function if string is not null terminated

consistent coding style: usage() declaration, eval is a constant

Merge pull request #34 from parazyd/master

refactor vol_perc to not depend on alsa libraries

why releases for such a small project? useless and overhead!

#undef strlcpy not needed anymore

tested wifi

Merge pull request #32 from R41z/master

several bugfixes and general improvements, see commits below.

kernel_release() coding style and position in code fix

Merge pull request #30 from TheMRod/master

Add a "uname -r" feature to see which kernel is running

Merge pull request #25 from jodizzle/dev/swap

Add functions for measuring swap

Merge pull request #24 from jodizzle/feat/mute

Restore "mute" message

Merge pull request #23 from R41z/master

get rid of unused variable (silly gcc did not report that error)

added quinq to contributors

add setlocale() (mostly for datetime function)

check daemon() return value

fixed run_command()

fixed run_command()

removed unnecessary fp, shorter return 0 and fixed compiler warning in vol_perc

Merge pull request #20 from R41z/master

fix division by zero in vol_perc, and hostname() rewrite

added name to LICENSE

better default config.h

3.0

braces for one line statements in smprintf()

shorter copyright notice and moved back VERSION and _GNU_SOURCE as the man page version number fails

Merge pull request #19 from R41z/master

several changes

updated man page according to readme

added -v to manpage

lol, dwm != slstatus in manpage :D

README.md reloaded

suckless coding style -> added back function prototypes argument variable names

config.mk comment about -Wno-unused-functions

optimization

added -v command line option

simpler usage

do not exit on failed smprintf

added man page

added man page

added optimization back (removed it for debugging some time ago)

n/a for run_command()

fuck newlines

removed TODO.md

moved headers to extern

shorter names

only open and close display if output type is dwm

coding style fixes + better var names

added daemonization, output possibility to console (for other programs) and moved the code to set WM_NAME to its own function as it is needed two times

fixed run_command()

Merge pull request #18 from R41z/master

simplified run_command()

Merge pull request #17 from R41z/master

improved hostname()

do not overwrite config.h if config.def.h changes

hostname() null terminaiton subtraction *is* needed

Merge pull request #16 from R41z/master

several improvements && memory leak fix.

battery_state() function added

fixed vol_perc() typo and added % sign again

simplified vol_perc() (and with that config.def.h is super clean)

lol, battery_perc() is even simpler, fuck this shit :D

simplified battery_perc() a lot and removed useless options from config.def.h

loop's not needed anymore

set old WM_NAME content before exiting

sighandle forgot const

signal handling to exit gracefully + small coding style fixes

simplify status_string clearing

Fixes issue #15. Forgot to close() a socket in wifi_essid()...

coding style (global variables)

Merge pull request #14 from R41z/master

cpu_perc() workaround

fixed wifi_perc() typo

added my fancy icon

brought back update interval

removed more unneeded comments

fixed username function (wtf happened here?)

fixed run_command behaviour for emtpy command output (uninitialized)

coding style fixes

removed that status_reset (we will do that with signals) and loop.sh (we wont need it)

Merge branch 'R41z-master'

remove screenshot

update sloc count in readme

remove todo item

suckless coding style fix -> remove slstatus.h

added all functions to readme

added uptime function

load avg

added configuration option for n/a text

Added \n to all error messages.

Removed the debug gcc flags

Formatting commit :(

I know formatting commits suck... And I try to avoid them.

But this commit was absolutely necessary... The coding style in this
program was not ok and not the same over the whole program.

The commit is hard to read, but this is what I changed:
- Tabs for indentation instead of spaces
- Same style over the whole program (suckless style)

simplified ram function

simplified wifi_essid by removing one malloc()

this project is now licensed under the ISC license

added wifi essid

fixed strcat null possibility in main()

fixed strlen-bomb in run_command

fixed memleak in datetime()

void argument main()

Fixed alsa function + datetime function

Added shell command function

revised readme

revised readme

README update (included information)

added, username, gid, uid

added disk functions for details

added memory values ram functions

fixed hostname function and added HOST_NAME_MAX limit

hostname function

added ip address function

added entropy

Added icon to TODO.md

typo license != license.md :P

Changes to documentation and new screenshot.

- Better README.md
- Headlines in all files
- CONTRIBUTING.md
- New screenshot

Easier info function names

All the info function names started with "get_", which I removed to make
it easier for the user to configure the program to its needs.
Additionally I renamed some functions (e.g. get_ram_usage) to better
names, making it easier to extend the program with ram usage / total
functions.

Merge pull request #10 from sahne/master

Fix some memory leaks

added license info to slstatus.h

header

removed from todo

added some todos

disk usage in README.md

completely new system: only values in config file get updated + cleaner code

whitespace error

removed todo

fixed disk percent

Merge pull request #9 from sahne/master

Add diskusage support

Update README.md

Create TODO.md

Merge pull request #8 from Vlaix/master

Fixed locale defaulting to English

added update_interval check to config_check()

coding style notice in README.md

added sahne to contributors

fixed some small things (update_interval) interferes with get_cpu_usage() and reordered)

Merge pull request #6 from sahne/master

minor cleanups and sanity checks

simplified config.def.h

Merge pull request #5 from Vlaix/master

Fixed small buffer in get_datetime()

better screenshot

small changes (var names)

starting in README.md

put everything in logical order

Merge pull request #4 from Vlaix/ram

Changed RAM calculation formula.

contributors

changed to easier variable names

changed to 4 spaces indentation (2 are not enough)

Merge pull request #3 from Vlaix/master

Fixed broken wifi

Merge pull request #2 from pfannkuchengesicht/master

fixed some memory leaks

fixed tabs xD

fixed typo in README.md (jpg <-> png)

added screenshot

variable names

commented and reordered

revised everything

added config.def.h handling and fixed typo

initial commit

Initial commit

fixed some memory leaks

Fixed broken wifi
Fixed indentation
Removed trailig white spaces

Changed RAM calculation formula.

Former : MemTotal - MemAvailable
New : (MemTotal - MemFree) - (Buffers + Cached)

Fixed small buffer in get_datetime()

The buffer being hardcoded to 19 (the size expected from the default time format),
strftime() would fail on any format returning a longer buffer.
Changed it from 19 to 64 to accomodate longer formats.

return n/a instead of exiting if a specific value cannot be read

add config checks on startup for better error handling

add update_interval

add a short sleep to reduce load

make config.h target depending on config.def.h

simplify smprintf by using vasprintf

Fixed locale defaulting to English

Changed get_datetime() a bit so it respects the user-configured locale (to use time formats with strings for days, months etc.)

Same commit as last time, except it merges.

Add diskusage support

add support to show used disk for a given mountpoint

Fix some memory leaks

use warn[x]() instead of long fprintf()s

used ccat() from concat.h for string concatenation

fixed some mistakes

what kind of weed is that?

bringed back the old config.mk

bringed back the old config.mk

bringed back the loop

imported a new vol_perc() function, this should fix #12 (UNTESTED)

added a tool for resetting the status bar && worked around some issues && removed the makefile (we need a better one)

config.mk cleanup

added daemonization support

removed UPDATE_INTERVAL, it is neat to have it but removing it is a tradeoff worth making, because the clock would act weird if this used to work with cpu_perc().

removed setstatus() && simplified main()

NOTREACHED comment

simplified gid()

simplified uid() and fixed username()

removed unnecessary typecast and added more comments

removed unneeded headers

opened the file before the path concatenates, what an idiot

forgot to give entropy() some candy too

slow down boy! you opened the file too early!

removed vol function from the default config file

got rid of conditional assignments && improved the error messages to output more info && added bound checks for fscanf() in hostname() (a dirty hack) && fixed a bug or two && some tiny style corrections

used a different implementation of smprintf() imported from dwmstatus

worked around the buffer overrun in smprintf()

removed heap dependency in datetime() and simplified the function

FIXME: buffer overflow warning

removed a misplaced ';'

used constant string literals && remote initialization to  in battery_perc() && trying to fix possible buffer overflow

grammar correction

removing typecasts for pcm_mixer cause more issues than before

typofix && another update

another update to README

README update

removed unnecessary typecasts (might be a reason for snd_mixer_selem_get_playback_volume_range bug

status_string can hold 4096 bytes now

fixed compiler warnings in a better way

corrected the time format

rm .config.h.swp

fixed the code, works now

Added myself to CONTRIBUTORS.md by drkh5h's request

(void)ed the prototypes

set local function as static

-Wextra

the code describes itself, there is no need to write stories in /* */

braces are unneeded for one-liner if()/while()

added bounds checking via secure strl*() routines

fixed (hopefully) the vol_perc() function

fixed cpu_perc() stupidity && added some useful comment for drkh5h

malloc sucks, you know?

* != **

minor improvements and memory leak fix

Merge branch 'master' of https://github.com/drkh5h/slstatus

subtraction is unneeded

improved hostname()

variable initialization is back

simplified run_command()

several changes

hostname: use POSIX routine to get hostname rather than reading from procfs

vol_perc: return zero if the value of max is set to zero

get rid of unused variable (silly gcc did not report that error)

vol_perc: Return "mute" when mixer is muted

This feature was originally removed as part of 52d19f9.

swap: Print UNKNOWN_STR if no swap is allocated

Update README.md

Edit config.def.h function descriptions

Add functions for measuring swap

Add "uname -r" functionality

Merge branch 'master' into master

fix TODO markdown syntax && update

add braces to single statements so drkhsh doesn't be upset

usage(): return success if -h is called && print more appropriate usage, opts can't be all called at the same time, that's why a separator is required

another TODO update

TODO update

homepage update

extern/concat.h: don't segfault if count == 0

whhops, my bad

wifi_essid: add boundary check && prevent the use of direct string literal as a format string in snprintf()

don't allow the use of perc if uninitialized

remove misleading comment

get rid of set_status() since it's only used once

allow the use of %* symbols in UNKNOWN_STR

add extra error tests to swap_*() && fix bytes_read bug

swap_*(): add more error tests

fix delay in a cleaner way

remove newlines from warn() in swap_*(), those functions already print a newline after printing string stderr

inititalize run_command()'s buf to UNKNOWN_STR by default

remove newline character from run_command() output accurately

strtok() has no effect on buf && fgets() should have the full buffer length

whhops

remove unused strlcpy() and reduce the size of output buffer

Merge branch 'master' into master

add vol_perc notes, add braces to singleline statements

refactor vol_perc to not depend on alsa libraries

Fixed out of boundary write on long lines.

The terminating nul character ('\0') could be written outside the boundary of
the buffer which is used to read characters. If "sizeof(buffer)" characters
are read, the resulting value must not be used as index, because that's an off
by one.

Read sizeof(buffer)-1 bytes instead.

Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org>

On success, fgets always terminates the result.

If fgets succeeds, then the resulting char array is always
terminated by a '\0'. No need to keep extra space, therefore
sizeof(buf) is the correct argument.

Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org>

Print unknown_str in case of error

func can return NULL in case of error, but no checking is done when
printing, and unknown_str wasn't being used anywhere.